Reduce attester state copies #6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This significantly reduces the amount of head state copy for RPC attester from
ASSIGNED_COMMITTED_COUNTdown to 1. With great saving when there's multiple keys, because chances are a validator client are assigned to more than 1 committee. In the current experiment, we see with 50 validators, the validator client are very often assigned to 8 committees per slot. That's 7 extra copies saved. This works because shard is not in play for phase 0, all committees are the same from beacon node's perspective.Gated behind feature flag
--reduce-attester-state-copyWhich issues(s) does this PR fix?
Fixes #5961
Other notes for review
Tested it locally for 12 hours with 4k validators. This saves ~1GB run time memory. For 4k, less than 1.5GB memory used. The for attester's head state copy is gone