Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes overflow issue in sync/pending_blocks_queue #6039

Merged
merged 3 commits into from May 29, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • Fixes possible overflow

Which issues(s) does this PR fix?

Fixes #6038

Other notes for review
N/A

@farazdagi farazdagi added Ready For Review A pull request ready for code review OK to merge labels May 29, 2020
@farazdagi farazdagi requested a review from nisdas May 29, 2020 10:00
@farazdagi farazdagi requested a review from a team as a code owner May 29, 2020 10:00
@farazdagi farazdagi self-assigned this May 29, 2020
@farazdagi farazdagi changed the title fixes overflow issue Fixes overflow issue in sync/pending_blocks_queue May 29, 2020
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #6039 into master will increase coverage by 0.06%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master    #6039      +/-   ##
==========================================
+ Coverage   59.57%   59.63%   +0.06%     
==========================================
  Files         320      320              
  Lines       26983    26991       +8     
==========================================
+ Hits        16075    16096      +21     
+ Misses       8717     8713       -4     
+ Partials     2191     2182       -9     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 0243bdc into master May 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-overflow branch May 29, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible overflow in sync/pending_blocks_queue
2 participants