Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Consistent ListValidators RPC Results #6054

Merged
merged 9 commits into from Jun 1, 2020
Merged

Conversation

rauljordan
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

The current RPC ListValidators endpoint returns inconsistent results as it uses the head state instead of the current, time-based epoch to determine active validators. This PR fixes to align with the desired behavior and runs process slots over the beacon state if needed.

Which issues(s) does this PR fix?

Fixes #5933

@rauljordan rauljordan requested a review from a team as a code owner May 29, 2020 21:08
@rauljordan rauljordan self-assigned this May 29, 2020
@rauljordan rauljordan added the Ready For Review A pull request ready for code review label May 29, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit c23ac85 into master Jun 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the bad-list-vals branch June 1, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListValidators is returning incorrect / unreliable results
2 participants