Reset Streams Properly #6066
Merged
Reset Streams Properly #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
On long running nodes, profile snapshots constantly showed a larger growing heap. Initially it was not obvious what was the root cause, but after a while it became clear that a large amount of streams were not cleaned up properly. While in most situations closing the stream is fine, as the other user will also close the stream on their end too. This allows the yamux session to remove the dead stream and clean it up. However there are situations when the other peer does not reply back or no messages are received,etc. This leads to the stream being left open and not being cleaned up. While it was not an issue with 30 peers, it becomes much worse with a larger number of peers over a period of time.
Which issues(s) does this PR fix?
N.A
Other notes for review
N.A