Simplified validator flags #6108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Jun 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #6108 +/- ##
==========================================
- Coverage 59.91% 59.60% -0.31%
==========================================
Files 324 323 -1
Lines 27756 27316 -440
==========================================
- Hits 16629 16283 -346
+ Misses 8896 8831 -65
+ Partials 2231 2202 -29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Different operations on validators require the same flags, but flag names cannot duplicate. This PR merges flags to avoid redundancy in commands such as
accounts merge --merge-source-dir.Which issues(s) does this PR fix?
N/A
Other notes for review