Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert gfind is available on OSX, for protobufs updates #6112

Merged
merged 3 commits into from Jun 3, 2020
Merged

Assert gfind is available on OSX, for protobufs updates #6112

merged 3 commits into from Jun 3, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • allows running ./scripts/update-go-ssz.sh an ./scripts/update-go-pbs.sh on OSX (where find is not GNU compatible)

Other notes for review

  • OSX's version of find doesn't have -regexptype flag, so those scripts weren't working
  • OSX has GNU compatible version, installable via brew install findutils
  • So, if we are on OS, script checks whether gfind is available (GNU compatible find):
    image
  • If gfind is avaialble, it is used:
    image

@farazdagi farazdagi added the Ready For Review A pull request ready for code review label Jun 3, 2020
@farazdagi farazdagi self-assigned this Jun 3, 2020
@farazdagi farazdagi marked this pull request as ready for review June 3, 2020 20:48
@farazdagi farazdagi requested a review from a team as a code owner June 3, 2020 20:48
@prylabs-bulldozer prylabs-bulldozer bot merged commit c945112 into master Jun 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-protobuf-upd-scripts branch June 3, 2020 21:15
@prestonvanloon prestonvanloon mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@terencechain terencechain Awaiting requested review from terencechain

@nisdas nisdas Awaiting requested review from nisdas

Assignees

@farazdagi farazdagi

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@farazdagi @rauljordan