Re-enable previous fetching algorithm testing #6125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
added
OK to merge
Ready For Review
Codecov Report
@@ Coverage Diff @@
## master #6125 +/- ##
==========================================
+ Coverage 59.66% 59.82% +0.15%
==========================================
Files 323 323
Lines 27358 27357 -1
==========================================
+ Hits 16323 16366 +43
+ Misses 8823 8773 -50
- Partials 2212 2218 +6 |
nisdas
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other/Better Testing
What does this PR do? Why is it needed?
EnableInitSyncWeightedRoundRobinwas introduced some parts of the code path were deactivated in tests (we set the flag to true, and that causes some parts of code to be ignored in tests). This is not ideal as we still use the code in production. This PR makes sure that the same code is run using different flags - so is tested using both previous (blocks interleaved) and current fetching algos.Other notes for review
fetchBlocksFromPeershttps://codecov.io/gh/prysmaticlabs/prysm/src/master/beacon-chain/sync/initial-sync/blocks_fetcher.go#L288 is all red now:This should be fixed by this PR.