Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enables multi-failure test case in round robin #6143

Merged
merged 1 commit into from Jun 5, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • There is a commented out test case in init-sync's round robin test file. I suppose there were some issues with multi-failure test case (it was commented out on previous implementation of syncing) - thus it was commented out.
  • Our current implementation is capable of processing such multiple bad peers w/o any issues, so the case is re-enabled.

Which issues(s) does this PR fix?
N/A

Other notes for review

@farazdagi farazdagi added Ready For Review A pull request ready for code review OK to merge labels Jun 5, 2020
@farazdagi farazdagi requested a review from nisdas June 5, 2020 10:34
@farazdagi farazdagi requested a review from a team as a code owner June 5, 2020 10:34
@farazdagi farazdagi self-assigned this Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #6143 into master will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6143      +/-   ##
==========================================
- Coverage   60.01%   59.80%   -0.21%     
==========================================
  Files         323      323              
  Lines       27674    27386     -288     
==========================================
- Hits        16608    16378     -230     
+ Misses       8817     8789      -28     
+ Partials     2249     2219      -30     

@prylabs-bulldozer prylabs-bulldozer bot merged commit fd3cb0b into master Jun 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the init-sync-rr-multifailure-test branch June 5, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants