Force manual validator account creation #6165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6165 +/- ##
==========================================
+ Coverage 59.76% 59.89% +0.13%
==========================================
Files 323 323
Lines 27351 27415 +64
==========================================
+ Hits 16347 16421 +74
+ Misses 8781 8774 -7
+ Partials 2223 2220 -3 |
rauljordan
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
UX Improvement
What does this PR do? Why is it needed?
This PR removes the automatic creation of a validator account if no information is passed in and a validator key doesn't exist. This would often confuse users and is just a user path we shouldn't allow.
This PR fixes #5494