Address Review of v0.12 #6179
Merged
Address Review of v0.12 #6179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested review from
farazdagi,
shayzluf and
prestonvanloon
and removed request for
a team
terencechain
reviewed
Jun 9, 2020
| @@ -211,19 +217,22 @@ func (vs *Server) SubscribeCommitteeSubnets(ctx context.Context, req *ethpb.Comm | |||
| return uint64(len(vals)), nil | |||
| } | |||
|
|
|||
| // run first request | |||
| // request the head validator indices of | |||
There was a problem hiding this comment.
Why are the comments formatted like this?
terencechain
reviewed
Jun 9, 2020
| @@ -195,11 +198,14 @@ func (vs *Server) ProposeAttestation(ctx context.Context, att *ethpb.Attestation | |||
|
|
|||
| // SubscribeCommitteeSubnets subscribes to the committee ID subnet given subscribe request. | |||
| func (vs *Server) SubscribeCommitteeSubnets(ctx context.Context, req *ethpb.CommitteeSubnetsSubscribeRequest) (*ptypes.Empty, error) { | |||
| ctx, span := trace.StartSpan(ctx, "AttesterServer.SubscribeCommitteeSubnets") | |||
| defer span.End() | |||
|
|
|||
| if len(req.Slots) != len(req.CommitteeIds) && len(req.CommitteeIds) != len(req.IsAggregator) { | |||
| return nil, status.Error(codes.InvalidArgument, "request fields are not the same length") | |||
| } | |||
| if len(req.Slots) == 0 { | |||
There was a problem hiding this comment.
what happen during genesis when attesters request for slot 0?
There was a problem hiding this comment.
req.Slots will still have len 1 in this case
There was a problem hiding this comment.
ah yes, i was thinking the actual slot number. my b!
…o tidy-up-comments
…into v0.12Review
rauljordan
approved these changes
Jun 9, 2020
prestonvanloon
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Review Cleanup
What does this PR do? Why is it needed?
Fixes some issues from review of #5614
Which issues(s) does this PR fix?
N.A
Other notes for review
N.A