Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inverts enable-init-sync-wrr flag #6187

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Inverts enable-init-sync-wrr flag #6187

merged 1 commit into from
Jun 9, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other/Flag Inversion

What does this PR do? Why is it needed?

  • Enables weighted round robin fetching (when data batch is fetched from a single peer - with fetching priority determined by weighted round robin)
  • enable-init-sync-wrr -> disable-init-sync-wrr

Which issues(s) does this PR fix?

Part of #6024

Other notes for review

  • The enable-init-sync-wrr was part of --dev, so whenever we used --dev the flag was enabled.

@farazdagi farazdagi self-assigned this Jun 9, 2020
@farazdagi farazdagi mentioned this pull request Jun 9, 2020
Closed
6 tasks
@farazdagi farazdagi marked this pull request as ready for review June 9, 2020 19:11
@farazdagi farazdagi requested a review from a team as a code owner June 9, 2020 19:11
@farazdagi farazdagi added OK to merge Ready For Review A pull request ready for code review labels Jun 9, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 187e08d into master Jun 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the invert-enable-init-sync-wrr-flag branch June 9, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@terencechain terencechain Awaiting requested review from terencechain

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees

@farazdagi farazdagi

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@farazdagi @rauljordan