Use Same Host for both JSON-HTTP and GRPC #6197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into removeHardLimit # Conflicts: use same host
nisdas
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6197 +/- ##
==========================================
- Coverage 59.79% 59.72% -0.08%
==========================================
Files 322 322
Lines 27485 27301 -184
==========================================
- Hits 16435 16305 -130
+ Misses 8793 8775 -18
+ Partials 2257 2221 -36 |
4 tasks
|
Superseded by #6202 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
Uses the same host for both grpc and json-http. This allows it to be
configurable.
Which issues(s) does this PR fix?
Fixes #6196
Other notes for review
Introduced in #5614