Reduce JSON-RPC queries #6221
Merged
Reduce JSON-RPC queries #6221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Jun 11, 2020
beacon-chain/powchain/service.go
Outdated
| @@ -613,9 +606,13 @@ func (s *Service) run(done <-chan struct{}) { | |||
|
|
|||
| s.initPOWService() | |||
|
|
|||
| ticker := time.NewTicker(1 * time.Second) | |||
| ticker := time.NewTicker(5 * time.Minute) | |||
There was a problem hiding this comment.
can we instead change this to the eth1 block time ?
There was a problem hiding this comment.
In that case, we don't need a second ticker. I've just combined this with the headTicker case in the select statement.
Codecov Report
@@ Coverage Diff @@
## master #6221 +/- ##
=======================================
Coverage 59.90% 59.90%
=======================================
Files 322 322
Lines 27337 27337
=======================================
Hits 16375 16375
Misses 8730 8730
Partials 2232 2232 |
…m into reduce-json-rpc-calls
terencechain
approved these changes
Jun 12, 2020
nisdas
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This reduces the total 1 request per second call to ETH1 to ETH1 block seconds interval
Given that we only need to process logs after a new ETH1 follow distance voting around (1024 slots), these calls to ETH1 should be rather infrequent.
Setting this to 5 minutes for now to relieve the immediate pressure on users.Set to ETH1 block time interval based on feedback.Which issues(s) does this PR fix?
Fixes #6206
Other notes for review
Also deleted "client" field which was unused.