Do Not Ignore Max Gateway Size gRPC #6232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
API
terencechain
approved these changes
Jun 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #6232 +/- ##
==========================================
+ Coverage 59.66% 59.90% +0.24%
==========================================
Files 341 323 -18
Lines 29513 27384 -2129
==========================================
- Hits 17609 16405 -1204
+ Misses 9477 8743 -734
+ Partials 2427 2236 -191 |
lee51525125
pushed a commit
to lee51525125/prysm
that referenced
this pull request
Jun 15, 2020
* do not ignore max message size in gateway * fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
We were ignoring the max grpc message size in the grpc gateway unless the --enable-debug-rpc-endpoints flag was on, which doesn't make sense as they should not depend on each other.
Which issues(s) does this PR fix?
Fixes #6068
Other notes for review