Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove Excess State Copies" #6240

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jun 14, 2020

Reverts #6142

@nisdas nisdas requested a review from a team as a code owner June 14, 2020 06:06
@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #6240 into master will increase coverage by 0.30%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #6240      +/-   ##
==========================================
+ Coverage   59.54%   59.84%   +0.30%     
==========================================
  Files         342      324      -18     
  Lines       29571    27435    -2136     
==========================================
- Hits        17608    16419    -1189     
+ Misses       9527     8778     -749     
+ Partials     2436     2238     -198     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 0067e52 into master Jun 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the revert-6142-removeCopies branch June 14, 2020 06:34
@prestonvanloon
Copy link
Member

Why was this reverted?

@prestonvanloon
Copy link
Member

It was causing tons of att sig fails to verify. Nishant said reverting fixed it
Plus the copy there isn't that bad given all the state miss / copy rate is something like 1% of the incoming atts

@terencechain

https://discordapp.com/channels/476244492043812875/483017808658169866/721784026096205964

lee51525125 pushed a commit to lee51525125/prysm that referenced this pull request Jun 15, 2020
* Revert "remove excess copies (prysmaticlabs#6142)"

This reverts commit c956905.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants