Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Peer As Bad After a Failed Validation #6250

Merged
merged 2 commits into from
Jun 14, 2020
Merged

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jun 14, 2020

What type of PR is this?

We occasionally ping and validate the status messages of our peers to check their liveness. In the event they are unreachable or give us bad data, we do disconnect these peers.

What does this PR do? Why is it needed?

It increments the peer counter on each failed validation. In the event we reach the threshold, we
will disconnect from them.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner June 14, 2020 09:38
@nisdas nisdas added the Ready For Review A pull request ready for code review label Jun 14, 2020
Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@terencechain terencechain merged commit 933ab68 into master Jun 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the markPeerAsBad branch June 14, 2020 14:10
lee51525125 pushed a commit to lee51525125/prysm that referenced this pull request Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants