QSP-4 Use Self-Signed, Secure gRPC Connection by Default #6428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Jun 26, 2020
61 tasks
rauljordan
requested review from
farazdagi,
terencechain,
nisdas,
0xKiwi,
prestonvanloon and
shayzluf
rauljordan
force-pushed
the
default-self-signed-certs
branch
from
6821d6e
to
82b5b78
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This pull request has been closed due to inactivity. Please reopen this pull request if you would like to continue working on it. |
|
@rauljordan re-opened this, please resolve tests and conflicts |
|
sorry, I just realised this was marked back to a draft, is this still relevant ? |
|
This pull request has been closed due to inactivity. Please reopen this pull request if you would like to continue working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Currently, beacon nodes set up an insecure gRPC connection by default unless cert and key flags are passed in. Our security audit instead recommended setting up encrypted communications by default. This PR creates self-signed certificates in datadir/cert.pem and datadir/key.pem when running a beacon node with default options. The beacon node then spins up a gRPC server using TLS configuration with this self-signed cert. The validator client then attempts to connect via TLS. Since it cannot verify the certificate authority properly (as it is self-signed), it will connect with an encrypted connection despite failing certificate authority verification.
Which issues(s) does this PR fix?
Part of #6327