Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused prune old states #6450

Merged
merged 3 commits into from Jun 29, 2020
Merged

Remove unused prune old states #6450

merged 3 commits into from Jun 29, 2020

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Jun 29, 2020

What type of PR is this?

code clean up

What does this PR do? Why is it needed?
remove unused code PruneOldState this was left over from defaulting block chain service to using new state mgmt

@terencechain terencechain added the Ready For Review A pull request ready for code review label Jun 29, 2020
@terencechain terencechain requested a review from a team as a code owner June 29, 2020 19:12
@terencechain terencechain self-assigned this Jun 29, 2020
shayzluf
shayzluf previously approved these changes Jun 29, 2020
Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shayzluf
Copy link
Contributor

gaz

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #6450 into master will decrease coverage by 1.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6450      +/-   ##
==========================================
- Coverage   61.09%   60.03%   -1.07%     
==========================================
  Files         355      355              
  Lines       28868    29520     +652     
==========================================
+ Hits        17638    17722      +84     
- Misses       8877     9433     +556     
- Partials     2353     2365      +12     

@terencechain terencechain merged commit 1f93a1f into master Jun 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the rm-prune-states branch June 29, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants