Integrate Accounts v2 Keymanager Into Validator Client #6489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it easy to include at runtime
rauljordan
added
AccountsV2
Ready For Review
Codecov Report
@@ Coverage Diff @@
## master #6489 +/- ##
==========================================
+ Coverage 60.07% 61.52% +1.44%
==========================================
Files 323 363 +40
Lines 27422 28330 +908
==========================================
+ Hits 16473 17429 +956
+ Misses 8733 8525 -208
- Partials 2216 2376 +160 |
prestonvanloon
approved these changes
Jul 7, 2020
0xKiwi
approved these changes
Jul 8, 2020
terencechain
requested changes
Jul 8, 2020
terencechain
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR begins integrating
--enable-accounts-v2into the validator client's runtime, allowing for full-featured functionality by using an EIP-2335 direct keystore manager implemented by #6466. This functionality will be gated by a feature flag until all keymanager implementations are complete and the code is deemed production ready.This PR additionally abstracts functionality of loading an existing keymanager configuration file into the
accountsv2.OpenWalletfunction, cleaning up some old code paths to ensure v2 functionality is simple to access.Which issues(s) does this PR fix?
Part of #6220