Init sync batch block clean up #6599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
|
cc @nisdas |
nisdas
reviewed
Jul 15, 2020
| lastBlk := blocks[len(blocks)-1] | ||
| lastRoot := blkRoots[len(blkRoots)-1] | ||
|
|
||
| if err := s.stateGen.SaveState(ctx, lastRoot, postState); err != nil { |
There was a problem hiding this comment.
I dont see how this works, we need to save the post state so that we can process the next batch. Otherwise state gen will have to regenerate the state when processing the next batch.
There was a problem hiding this comment.
Ah i see. I thought saving it per boundary would be enough. I'll add this back
There was a problem hiding this comment.
Added it here. 56ca04d
Going to test this now
|
Resolve conflicts @terencechain |
Codecov Report
@@ Coverage Diff @@
## master #6599 +/- ##
=======================================
Coverage 62.72% 62.72%
=======================================
Files 380 380
Lines 29882 29882
=======================================
Hits 18744 18744
Misses 8587 8587
Partials 2551 2551 |
rauljordan
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various clean ups to init sync batch block processing:
onBlockBatchonBlockBatchdoes not need to returnpostStatehandleEpochBoundarytoonBlockBatchinside at epoch starts.beaconDB.SaveBlocksands.clearInitSyncBlocks()as they are done ins.updateFinalizeds.stateGen.SaveStateanymore!bytes.Equal(lastRoot[:], cachedHeadRoot)is checked withins.saveHeadNoDB(ctx, lastBlk, lastRoot)