Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Faster Hash Function #6616

Merged
merged 5 commits into from Jul 16, 2020
Merged

Use Faster Hash Function #6616

merged 5 commits into from Jul 16, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jul 16, 2020

What type of PR is this?

Improvement

What does this PR do? Why is it needed?

  • Uses proto hash instead of ssz HTR, as it is currently much more efficient and doesn't rely on runtime reflection.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner July 16, 2020 11:59
@nisdas nisdas added the Ready For Review A pull request ready for code review label Jul 16, 2020
@rauljordan rauljordan merged commit cf2bbec into master Jul 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the useBetterHash branch July 16, 2020 15:19
@terencechain
Copy link
Member

Sorry i didnt have a chance to respond. This looks good to me. Thanks @nisdas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants