Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test found by fuzzer #6628

Merged
merged 1 commit into from Jul 18, 2020

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Jul 18, 2020

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

This prevents a panic out of range issue.

Which issues(s) does this PR fix?

N/A

Other notes for review

This bug was discovered by taking a randomized beacon state and advancing empty state transitions until the next epoch start.

Here's the beacon state that generated this input: crash-2994ca80dfcefc8e626f965c109dcc762710427e.zip

Reproduction steps:

  • UnmarshalSSZ
	nextEpoch := helpers.SlotToEpoch(s.Slot())+1
	if _, err := stateutil.ProcessSlots(context.Background(), s, helpers.StartSlot(nextEpoch)); err != nil {
		panic(err)
	}

@prestonvanloon prestonvanloon requested a review from a team as a code owner July 18, 2020 02:01
@prestonvanloon prestonvanloon added OK to merge Ready For Review A pull request ready for code review labels Jul 18, 2020
@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #6628 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6628      +/-   ##
==========================================
- Coverage   61.81%   61.80%   -0.01%     
==========================================
  Files         377      374       -3     
  Lines       29184    29281      +97     
==========================================
+ Hits        18039    18097      +58     
- Misses       8669     8697      +28     
- Partials     2476     2487      +11     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 0e4cb68 into master Jul 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the committee-cache-out-of-bounds branch July 18, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants