Voting With The Majority #6644
Merged
Voting With The Majority #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Jul 19, 2020
rkapka
commented
Jul 19, 2020
rkapka
commented
Jul 19, 2020
rkapka
commented
Jul 19, 2020
rkapka
commented
Jul 19, 2020
rkapka
commented
Jul 19, 2020
rkapka
commented
Jul 19, 2020
|
I've just noticed that this bit of logic was removed from the spec earlier this year in ethereum/consensus-specs#1553. When should look into why the spec is recommending to immediately vote with the majority, even if there is only a single vote. |
Codecov Report
@@ Coverage Diff @@
## master #6644 +/- ##
==========================================
- Coverage 62.46% 62.37% -0.09%
==========================================
Files 384 383 -1
Lines 29583 29419 -164
==========================================
- Hits 18479 18351 -128
- Misses 8466 8483 +17
+ Partials 2638 2585 -53 |
prestonvanloon
approved these changes
Jul 28, 2020
This was referenced Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
The aim of this PR is to enhance the proposer with a new voting algorithm as described here: https://hackmd.io/@prestonvanloon/H1rfsG5iH#Voting-With-The-Majority
Which issues(s) does this PR fix?
Fixes #4117
Other notes for review
There are someTODOs in the code because I need clarification on a couple of things. I would rather not guess how things should work by myself.