First take of applying assertion funcs to shared tests #6666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
terencechain
removed
the
Stale
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
21 tasks
terencechain
removed
the
Stale
Codecov Report
@@ Coverage Diff @@
## master #6666 +/- ##
=======================================
Coverage 62.09% 62.09%
=======================================
Files 408 408
Lines 32055 32055
=======================================
Hits 19906 19906
Misses 9351 9351
Partials 2798 2798 |
terencechain
changed the title
farazdagi
previously approved these changes
Aug 24, 2020
farazdagi
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other/Tests Refactoring
What does this PR do? Why is it needed?
First take of applying testutil/assert and testutil/require to part of shared tests. Please note that some may be missed but I think i was able to cover up to 80% of the statements. Let's merge this in first so we can open another one for the final clean up (in #7003).
Which issues(s) does this PR fix?
Part of #6590