-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accounts V2: Resolve Remaining Keymanager Bugs #6706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
changed the title
Accounts V2: Resolve Miscellaneous Keymanager Bugs
Accounts V2: Resolve Remaining Keymanager Bugs
Jul 23, 2020
rauljordan
added
AccountsV2
Ready For Review
A pull request ready for code review
labels
Jul 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #6706 +/- ##
==========================================
- Coverage 62.55% 62.18% -0.38%
==========================================
Files 384 384
Lines 29666 29427 -239
==========================================
- Hits 18558 18299 -259
- Misses 8497 8537 +40
+ Partials 2611 2591 -20 |
0xKiwi
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Part of #6220