Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts V2: Resolve Remaining Keymanager Bugs #6706

Merged
merged 15 commits into from
Jul 24, 2020

Conversation

rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Jul 23, 2020

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • Listing derived wallet with 0 accounts leads to a fatal
  • Recover shouldnt ask for the type of wallet desired
  • Recover didn’t ask me for the new password I want for my desired wallet
  • Using wrong recovery function from bip39
  • Implement remote keymanager accounts-v2 list
  • Sanitize all user input, both from files and from stdin
  • Interrupts during user input can lead to a corrupted wallet
  • Include Altona and Medalla feature flags in the accounts-v2 commands

Which issues(s) does this PR fix?

Part of #6220

@rauljordan rauljordan marked this pull request as ready for review July 23, 2020 23:34
@rauljordan rauljordan requested a review from a team as a code owner July 23, 2020 23:34
@rauljordan rauljordan changed the title Accounts V2: Resolve Miscellaneous Keymanager Bugs Accounts V2: Resolve Remaining Keymanager Bugs Jul 23, 2020
@rauljordan rauljordan self-assigned this Jul 23, 2020
@rauljordan rauljordan added AccountsV2 Ready For Review A pull request ready for code review labels Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #6706 into master will decrease coverage by 0.37%.
The diff coverage is 41.12%.

@@            Coverage Diff             @@
##           master    #6706      +/-   ##
==========================================
- Coverage   62.55%   62.18%   -0.38%     
==========================================
  Files         384      384              
  Lines       29666    29427     -239     
==========================================
- Hits        18558    18299     -259     
- Misses       8497     8537      +40     
+ Partials     2611     2591      -20     

@prylabs-bulldozer prylabs-bulldozer bot merged commit a5b4087 into master Jul 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the keymanager-bugs branch July 24, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants