Accounts V2: Add --num-accounts to HD wallet commands #6721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6721 +/- ##
==========================================
+ Coverage 60.07% 62.20% +2.13%
==========================================
Files 323 384 +61
Lines 27422 29519 +2097
==========================================
+ Hits 16473 18363 +1890
+ Misses 8733 8542 -191
- Partials 2216 2614 +398 |
rauljordan
approved these changes
Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Part of #6220 , this PR adds a flag
--num-accountsfor declaring how many accounts to be generated withaccounts-v2 createfor HD wallets. It also lets you define how many accounts to recover withwallet-v2 recoverwhen recovering a mnemonic phrase is complete.