Batch Block Roots Requesting #7027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
force-pushed
the
multipleBranchProcessing
branch
from
8ea515b
to
08f10f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #7027 +/- ##
==========================================
+ Coverage 60.07% 62.21% +2.14%
==========================================
Files 323 401 +78
Lines 27422 31398 +3976
==========================================
+ Hits 16473 19535 +3062
- Misses 8733 9093 +360
- Partials 2216 2770 +554 |
farazdagi
previously approved these changes
Aug 19, 2020
| @@ -49,6 +49,19 @@ func (s *Service) dedupBlocksAndRoots(blks []*ethpb.SignedBeaconBlock, roots [][ | |||
| return newBlks, newRoots, nil | |||
| } | |||
|
|
|||
| func (s *Service) dedupRoots(roots [][32]byte) [][32]byte { | |||
There was a problem hiding this comment.
Is this tested? I think we can add a duplicated root in TestService_BatchRootRequest to cover this function?
There was a problem hiding this comment.
great idea, will add that in
… into batchRootReq
terencechain
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Change
What does this PR do? Why is it needed?
of peers.
randomly trying out with any peer.
Which issues(s) does this PR fix?
N.A
Other notes for review