Voluntary exit CLI/Client integration #7162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # validator/accounts/v2/accounts_exit.go
rkapka
commented
Sep 2, 2020
terencechain
reviewed
Sep 2, 2020
| @@ -81,3 +81,5 @@ func TestExitAccountsCli_EmptyWalletReturnsError(t *testing.T) { | |||
| err = ExitAccountsCli(cliCtx, os.Stdin) | |||
| assert.ErrorContains(t, "wallet is empty, no accounts to perform voluntary exit", err) | |||
| } | |||
|
|
|||
| // TODO: Write an integration test? | |||
|
prysm/validator/accounts/v2/accounts_exit.go Lines 168 to 169 in c3eef97 I am Newing the clients and because of this I cannot use gomock to mock them. Is there any standard pattern that should be used here? Initialize them inside main() and pass into ExitAccountsCli() so that I can pass a mock implementation in tests?
|
# Conflicts: # validator/client/propose.go
rkapka
added
Ready For Review
Codecov Report
@@ Coverage Diff @@
## master #7162 +/- ##
==========================================
- Coverage 61.64% 61.53% -0.11%
==========================================
Files 411 410 -1
Lines 32628 32657 +29
==========================================
- Hits 20112 20095 -17
- Misses 9647 9693 +46
Partials 2869 2869 |
rauljordan
approved these changes
Sep 9, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
The aim of this PR is to provide full integration between the CLI command for performing an exit, the validator and the gRPC validator client.
Which issues(s) does this PR fix?
Part of #6882
Other notes for review
N/A