Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gazelle warning when fuzzing_enabled is not provided #7260

Merged
merged 2 commits into from Sep 17, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other/Toolset improve

What does this PR do? Why is it needed?

  • When running bazel run //:gazelle, I see the following gazelle warning:
    image
  • This PR makes sure that when fuzzing_enabled flag is not set, bazel run //:gazelle doesn't emit any warnings.

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi added Ready For Review A pull request ready for code review OK to merge labels Sep 17, 2020
@farazdagi farazdagi requested a review from a team as a code owner September 17, 2020 12:20
@farazdagi farazdagi self-assigned this Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #7260 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7260      +/-   ##
==========================================
- Coverage   61.83%   61.57%   -0.27%     
==========================================
  Files         417      417              
  Lines       33270    33109     -161     
==========================================
- Hits        20574    20386     -188     
- Misses       9763     9795      +32     
+ Partials     2933     2928       -5     

@prylabs-bulldozer prylabs-bulldozer bot merged commit e1e233a into master Sep 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-gazelle-warning branch September 17, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants