Add, use and test VerifyWeakSubjectivityRoot
#7344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
reviewed
Sep 25, 2020
| // Reference design: https://github.com/ethereum/eth2.0-specs/blob/master/specs/phase0/weak-subjectivity.md#weak-subjectivity-sync-procedure | ||
| func (s *Service) VerifyWeakSubjectivityRoot(ctx context.Context) error { | ||
| // TODO(7342): Remove the following to fully use weak subjectivity in production. | ||
| if len(s.wsRoot) == 0 && s.wsEpoch == 0 { |
There was a problem hiding this comment.
Either way is fine. This is not going to be production code. I changed it to | |
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Codecov Report
@@ Coverage Diff @@
## master #7344 +/- ##
==========================================
- Coverage 60.42% 60.09% -0.34%
==========================================
Files 418 417 -1
Lines 30316 29961 -355
==========================================
- Hits 18319 18004 -315
+ Misses 9029 9016 -13
+ Partials 2968 2941 -27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR adds in the weak subjectivity check as outlined in:
https://github.com/ethereum/eth2.0-specs/blob/master/specs/phase0/weak-subjectivity.md#weak-subjectivity-sync-procedure
This weak subjectivity check is currently opt-out. It'll switch to opt-in with the closure of issue #7342
Other notes for review
Tested run time under various conditions
1.) ws block not in db:
2.) ws block in db but incorrect epoch:
3.) ws check working during initial syncing
4.) ws check working for an almost caught up node
