Use validator protection datadir #7355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7355 +/- ##
=======================================
Coverage 61.81% 61.81%
=======================================
Files 422 422
Lines 29866 29866
=======================================
Hits 18461 18461
Misses 8453 8453
Partials 2952 2952 |
nisdas
requested changes
Sep 29, 2020
|
@nisdas reused the same flag |
…sm into add_protection_db_flag
rauljordan
reviewed
Oct 21, 2020
rauljordan
reviewed
Oct 21, 2020
rauljordan
reviewed
Oct 21, 2020
…sm into add_protection_db_flag
|
PTAL @prestonvanloon and @nisdas |
nisdas
reviewed
Oct 22, 2020
…ection_db_flag # Conflicts: # validator/flags/flags.go # validator/main.go # validator/node/BUILD.bazel # validator/usage.go
nisdas
reviewed
Oct 22, 2020
nisdas
previously approved these changes
Oct 22, 2020
|
PTAL @prestonvanloon |
prestonvanloon
approved these changes
Oct 22, 2020
rauljordan
added a commit
that referenced
this pull request
Oct 23, 2020
This reverts commit ab76bda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
why?
two reasons:
missing db file is a slashing protection problem. warn users and allow them to copy the db file if its empty
some users reported they don't have write permissions to wallet dir and need to configure a different location for it
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #7331