Fix config file flags in subcommands #7475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7475 +/- ##
==========================================
+ Coverage 60.47% 60.50% +0.03%
==========================================
Files 427 427
Lines 30380 30380
==========================================
+ Hits 18371 18381 +10
+ Misses 9012 9008 -4
+ Partials 2997 2991 -6 |
terencechain
requested changes
Oct 9, 2020
…fix-config-file-in-subcommands
…fix-config-file-in-subcommands
…fix-config-file-in-subcommands
terencechain
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7310
Other notes
Fixes the issue, but imho perfect solution would be to follow more strict usage of flags in their respected positions(global vs subcommand), to open a feature request in urfave/cli or to move to another cli package.