Remove feature flags within the scope of pkg #7511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
terencechain
force-pushed
the
ff-cleanup-part1
branch
from
ed038ad
to
0050a8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #7511 +/- ##
=======================================
Coverage 60.66% 60.66%
=======================================
Files 431 431
Lines 30624 30624
=======================================
Hits 18577 18577
Misses 9020 9020
Partials 3027 3027 |
prestonvanloon
previously approved these changes
Oct 14, 2020
prestonvanloon
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7509
This PR removed feature flags that were in scope of pkg. It means these feature flags weren't used which makes it easier to reason for removing