More feature flags removal #7526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
prestonvanloon
requested changes
Oct 14, 2020
Comment on lines
+32
to
+34
| state, err = executeStateTransitionStateGen(ctx, state, signed[i]) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
This looks wrong.
Previous implementation with the flag on was this
state, err := transition.ExecuteStateTransition(ctx, state, signed[i])
But now you are using executeStateTransitionStateGen? Why?
Why is this feature not being released, but removed?
There was a problem hiding this comment.
Discussed offline https://discordapp.com/channels/476244492043812875/483017808658169866/765740051450691604
This is OK to remove, the flag was never used and should have been in the form of DisableStateGenSigVerify. It was a safety net in case the state gen feature was not working properly.
| if err != nil { | ||
| return nil, err | ||
| } | ||
| state, err = processSlotsStateGen(ctx, state, targetSlot) |
prestonvanloon
previously approved these changes
Oct 14, 2020
prestonvanloon
previously approved these changes
Oct 14, 2020
…o ff-cleanup-part6
rauljordan
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7509
I removed the feature flags
disableStrictAttestationPubsubVerificationFlag,enableStateGenSigVerify,disableReduceAttesterStateCopy,disableBatchBlockVerify, anddisableDomainDataCacheFlag. The rationale for removal are outlined in #7509These are grouped in PR for ease to merge and resolve conflicts