Cache ETH1 headers on startup for eth1data voting #7541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # beacon-chain/powchain/service.go
rkapka
changed the title
rauljordan
reviewed
Oct 19, 2020
beacon-chain/powchain/service.go
Outdated
| blocksPerVotingPeriod := params.BeaconConfig().EpochsPerEth1VotingPeriod * params.BeaconConfig().SlotsPerEpoch * | ||
| params.BeaconConfig().SecondsPerSlot / params.BeaconConfig().SecondsPerETH1Block | ||
|
|
||
| end := lastKnownHeader.Number.Uint64() - params.BeaconConfig().Eth1FollowDistance |
There was a problem hiding this comment.
Check for underflow, even though this cant happen after block height 1024, it can mess up some people running dev goerli chains
rauljordan
reviewed
Oct 19, 2020
beacon-chain/powchain/service.go
Outdated
|
|
||
| end := lastKnownHeader.Number.Uint64() - params.BeaconConfig().Eth1FollowDistance | ||
| // We fetch twice the number of headers just to be safe. | ||
| start := end - 2*blocksPerVotingPeriod |
nisdas
reviewed
Oct 19, 2020
beacon-chain/powchain/service.go
Outdated
| blocksPerVotingPeriod := params.BeaconConfig().EpochsPerEth1VotingPeriod * params.BeaconConfig().SlotsPerEpoch * | ||
| params.BeaconConfig().SecondsPerSlot / params.BeaconConfig().SecondsPerETH1Block | ||
|
|
||
| end := lastKnownHeader.Number.Uint64() - params.BeaconConfig().Eth1FollowDistance |
There was a problem hiding this comment.
Please use the helper to calculate this:
prysm/beacon-chain/powchain/service.go
Line 341 in f31d40c
nisdas
reviewed
Oct 19, 2020
beacon-chain/powchain/service.go
Outdated
| _, err := s.batchRequestHeaders(start, end) | ||
| if err != nil { | ||
| // Caching failure is not critical, so we just log a warning. | ||
| log.Warningf("Unable to cache headers: %v", err) |
There was a problem hiding this comment.
this should be an error, failure to request headers could lead to a block proposal with invalid eth1data.
There was a problem hiding this comment.
Right. We no longer call the ETH1 endpoint when we have a cache miss.
rauljordan
approved these changes
Oct 19, 2020
0xKiwi
reviewed
Oct 19, 2020
| if err != nil { | ||
| return false, nil, err | ||
| } | ||
| span.AddAttributes(trace.BoolAttribute("blockCacheHit", true)) |
There was a problem hiding this comment.
Shouldn't this be a metric maintained with prometheus?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimization
What does this PR do? Why is it needed?
This PR caches ETH1 headers on POW initialization so that the cache can be utilized when voting for eth1data. This will optimize the voting algorithm because an RPC call to the ETH1 endpoint is made for every non-cached header.
Zinken testnet cache miss difference:
Which issues(s) does this PR fix?
N/A
Other notes for review
Unblocks #7362