Verify eth1data vote in E2E #7551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7551 +/- ##
==========================================
- Coverage 61.74% 61.61% -0.14%
==========================================
Files 424 424
Lines 29884 29897 +13
==========================================
- Hits 18452 18420 -32
- Misses 8473 8510 +37
- Partials 2959 2967 +8 |
rauljordan
approved these changes
Oct 19, 2020
0xKiwi
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
E2E improvement
What does this PR do? Why is it needed?
Adds an evaluator to verify that validators are voting for the correct eth1data block, according to the majority vote algorithm.
Which issues(s) does this PR fix?
N/A
Other notes for review
The logic is very simple. If we follow the majority, then all proposers after the initial proposer in a voting period should follow the initial proposer's vote.
I am not happy that there is one "hack" in place for epoch 1. I tried to document it as clearly as possible.