Use Password Specific to Web UI Instead of Wallet Password #7569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Oct 19, 2020
| if err != nil { | ||
| return errors.Wrap(err, "could not open wallet") | ||
| } | ||
| if w != nil { |
There was a problem hiding this comment.
If a user already has a wallet, we shouldn't block the validator client from starting if using --web
| } | ||
| }() | ||
| time.Sleep(time.Second * 1) | ||
| cmd, err := browser.Command("http://" + s.http.Addr) |
There was a problem hiding this comment.
This caused a lot more problems than it solved, removing
This was referenced Oct 19, 2020
Closed
0xKiwi
previously approved these changes
Oct 19, 2020
|
Needs gazelle |
rauljordan
force-pushed
the
web-specific-password
branch
from
506d3ef
to
6348e29
Compare
prestonvanloon
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a security measure, we should not be using the wallet password for web UI authentication. Instead, we should have a specific password we use for web UI access, which we store as a password hash in our validator DB. This will prevent us from sending the wallet password via gRPC every single time we login to the dashboard.
This PR also removes the automatic opening of the web UI in a user's browser, and it also removes the restriction that validator clients with existing wallet cannot start without logging in with the --web flag.