Invalidate JWT in Backend Logout #7574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
API
terencechain
previously approved these changes
Oct 19, 2020
prestonvanloon
previously approved these changes
Oct 20, 2020
prestonvanloon
approved these changes
Oct 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #7574 +/- ##
=======================================
Coverage 61.66% 61.66%
=======================================
Files 424 424
Lines 29894 29894
=======================================
Hits 18435 18435
Misses 8513 8513
Partials 2946 2946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR invalidates the validator RPC JWT token in the backend after calling the
Logout()method from the API. Currently, the frontend gets rid of its token during logout but it is not invalidated in the backend, which is a security risk