More verbose output on init-sync #7578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested changes
Oct 20, 2020
…into init-sync-more-logs
terencechain
previously approved these changes
Oct 20, 2020
nisdas
reviewed
Oct 20, 2020
| @@ -112,7 +112,7 @@ func (s *Service) processFetchedData( | |||
|
|
|||
| // Use Batch Block Verify to process and verify batches directly. | |||
| if err := s.processBatchedBlocks(ctx, genesis, data.blocks, s.chain.ReceiveBlockBatch); err != nil { | |||
| log.WithError(err).Debug("Batch is not processed") | |||
| log.WithError(err).Warn("Batch is not processed") | |||
There was a problem hiding this comment.
can you remove WithError it prints the whole stack trace which can get very noisy. We just want to print the main error
| @@ -124,7 +124,9 @@ func (s *Service) processFetchedDataRegSync( | |||
| blockReceiver := s.chain.ReceiveBlock | |||
| for _, blk := range data.blocks { | |||
| if err := s.processBlock(ctx, genesis, blk, blockReceiver); err != nil { | |||
| log.WithError(err).Debug("Block is not processed") | |||
| log.WithError(err).WithFields(logrus.Fields{ | |||
Codecov Report
@@ Coverage Diff @@
## master #7578 +/- ##
==========================================
+ Coverage 61.64% 61.66% +0.01%
==========================================
Files 423 423
Lines 29613 29622 +9
==========================================
+ Hits 18256 18265 +9
+ Misses 8439 8433 -6
- Partials 2918 2924 +6 |
nisdas
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
N/A
Other notes for review