Clean Up Block Retrieval Methods #7593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Oct 21, 2020
| } | ||
| // Return nothing with an end slot of 0. | ||
| if endSlot == 0 { | ||
| return [][]byte{}, nil |
There was a problem hiding this comment.
Shouldn't this return the genesis block?
There was a problem hiding this comment.
We always retrieve the genesis block by its root and not by slots to overcome the limitations of zero values in Go throughout the codebase
There was a problem hiding this comment.
Perhaps worth adding as a comment @nisdas
rauljordan
previously approved these changes
Oct 21, 2020
rauljordan
previously approved these changes
Oct 22, 2020
|
@nisdas looks like some DB tests fail |
| @@ -53,6 +53,10 @@ func (s *State) ReplayBlocks(ctx context.Context, state *stateTrie.BeaconState, | |||
| // LoadBlocks loads the blocks between start slot and end slot by recursively fetching from end block root. | |||
| // The Blocks are returned in slot-descending order. | |||
| func (s *State) LoadBlocks(ctx context.Context, startSlot, endSlot uint64, endBlockRoot [32]byte) ([]*ethpb.SignedBeaconBlock, error) { | |||
| // Nothing to load for invalid range. | |||
| if endSlot < startSlot { | |||
| return nil, nil | |||
There was a problem hiding this comment.
Discussed offline that this breaks many tests. We'll revisit at a later time. @nisdas suggested filing an issue and TODO for this, to fix the test input data.
prestonvanloon
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Code Quality
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review