VerifyFinalizedConsistency - return early when canonical #7628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
Codecov Report
@@ Coverage Diff @@
## master #7628 +/- ##
=======================================
Coverage 61.87% 61.88%
=======================================
Files 422 422
Lines 29802 29719 -83
=======================================
- Hits 18441 18391 -50
+ Misses 8429 8412 -17
+ Partials 2932 2916 -16 |
prestonvanloon
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a condition to satisfy that canonical root implies to have the same ancestor as finalized check point. The benefit of this is savings of cpu cycles. Before and after graphs 馃憞
Verified run time and p2p messages counter in metric