Update delete state(s) functions #7754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
previously approved these changes
Nov 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #7754 +/- ##
==========================================
- Coverage 62.15% 62.14% -0.02%
==========================================
Files 429 429
Lines 30248 30245 -3
==========================================
- Hits 18802 18797 -5
- Misses 8521 8522 +1
- Partials 2925 2926 +1 |
prestonvanloon
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves on the design for the delete state functions:
DeleteStatesput everything under 1 TX, that means it either all works or none of it worksDeleteStates, Instead of doing one big update, it's better to do one at a timeDeleteStatestoDeleteStatewithout the cursor, and updatedDeleteStatesto just callDeleteState