Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous Keystore Fixes #7756

Merged
merged 7 commits into from
Nov 10, 2020
Merged

Miscellaneous Keystore Fixes #7756

merged 7 commits into from
Nov 10, 2020

Conversation

rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Nov 10, 2020 •
edited

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

This PR fixes 2 issues in accounts:

  • Imported keymanager attempts to always rewrite the keystore file on disk on startup, which should not happen and now throws a breaking bug for users given that Prevent Usage of Stdlib File/Dir Writing With Static Analysis #7685 was just merged
  • Warn users about the keys they are attempting to delete for them to ensure they are indeed deleted

Related to #7752

@rauljordan rauljordan requested a review from a team as a code owner November 10, 2020 01:35
@rauljordan rauljordan self-assigned this Nov 10, 2020
@rauljordan rauljordan added OK to merge Ready For Review A pull request ready for code review and removed OK to merge labels Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020 •
edited

Codecov Report

Merging #7756 (03edb37) into master (e22dd37) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7756      +/-   ##
==========================================
+ Coverage   62.06%   62.09%   +0.03%     
==========================================
  Files         429      429              
  Lines       30379    30370       -9     
==========================================
+ Hits        18854    18859       +5     
+ Misses       8583     8568      -15     
- Partials     2942     2943       +1

terencechain
terencechain previously approved these changes Nov 10, 2020
View reviewed changes
@rkapka rkapka merged commit 7f7d18e into master Nov 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the accounts-fix branch November 10, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka left review comments

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@terencechain terencechain terencechain approved these changes

@farazdagi farazdagi Awaiting requested review from farazdagi

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@nisdas nisdas Awaiting requested review from nisdas

Assignees

@rauljordan rauljordan

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rauljordan @prestonvanloon @terencechain @rkapka