Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Terminate Log Processing Early #7757

Merged
merged 7 commits into from
Nov 10, 2020
Merged

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 10, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Fixes an edge case hit in toledo.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner November 10, 2020 02:38
@nisdas nisdas added the Ready For Review A pull request ready for code review label Nov 10, 2020
terencechain
terencechain previously approved these changes Nov 10, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit f57bab7 into master Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #7757 (1897718) into master (d4c9546) will decrease coverage by 0.01%.
The diff coverage is 56.79%.

@@            Coverage Diff             @@
##           master    #7757      +/-   ##
==========================================
- Coverage   62.15%   62.14%   -0.02%     
==========================================
  Files         429      429              
  Lines       30248    30294      +46     
==========================================
+ Hits        18802    18827      +25     
- Misses       8521     8537      +16     
- Partials     2925     2930       +5     

@delete-merged-branch delete-merged-branch bot deleted the removeCondition branch November 10, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants