Honor the --max-msg-size option in the gRPC service. #7762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7762 +/- ##
=======================================
Coverage 62.12% 62.13%
=======================================
Files 429 429
Lines 30361 30365 +4
=======================================
+ Hits 18863 18866 +3
+ Misses 8557 8556 -1
- Partials 2941 2943 +2 |
terencechain
approved these changes
Nov 10, 2020
terencechain
added
Ready For Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This passes the
--max-msg-sizeoption to the gRPC service. It is currently passed to the gateway service, but not the gRPC service itself.This is required to pass large sets of information (e.g. large validator lists) to the gRPC without triggering a
ResourceExhaustederror.