Add configurable deposit amounts to testutil #7775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7775 +/- ##
==========================================
+ Coverage 62.17% 62.21% +0.03%
==========================================
Files 429 429
Lines 30340 30340
==========================================
+ Hits 18863 18875 +12
+ Misses 8541 8530 -11
+ Partials 2936 2935 -1 |
rauljordan
reviewed
Nov 11, 2020
shared/testutil/deposits_test.go
Outdated
| "github.com/gogo/protobuf/proto" | ||
|
|
||
| "github.com/prysmaticlabs/prysm/shared/params" | ||
|
|
rauljordan
reviewed
Nov 11, 2020
| } | ||
| sigRoot, err := (&pb.SigningData{ObjectRoot: root[:], Domain: domain}).HashTreeRoot() | ||
| balance := params.BeaconConfig().MaxEffectiveBalance | ||
| deposit, err := signedDeposit(secretKeys[i], publicKeys[i].Marshal(), publicKeys[i+1].Marshal(), balance) |
There was a problem hiding this comment.
any check here that i+1 wont exceed the list size?
There was a problem hiding this comment.
Not required, above we generate it with a +1 as well.
| if len(balances) == int(numDeposits) { | ||
| balance = balances[i] | ||
| } | ||
| deposit, err := signedDeposit(secretKeys[i], publicKeys[i].Marshal(), publicKeys[i+1].Marshal(), balance) |
rauljordan
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Test helper additions
What does this PR do? Why is it needed?
This PR adds extra deposit helpers to allow creating deterministic deposits with custom balances. It uses any available cache of secret keys and generates any if it needs.
This is in preparation for testing partial deposits in E2E.