Enable head sync only during period of non-finality #7784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7784 +/- ##
==========================================
+ Coverage 62.19% 62.25% +0.05%
==========================================
Files 429 429
Lines 30349 30358 +9
==========================================
+ Hits 18877 18898 +21
+ Misses 8534 8518 -16
- Partials 2938 2942 +4 |
terencechain
requested changes
Nov 11, 2020
…:prysmaticlabs/prysm into disable-head-sync-before-finalized-epoch
terencechain
approved these changes
Nov 12, 2020
delete-merged-branch
bot
deleted the
disable-head-sync-before-finalized-epoch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
--head-synchelps us not to re-fetch blocks which have already been fetched and saved in DB. However, if node's finalization checkpoint is close enough to last saved head, then it is better to just use the finalized epoch on restarts.--head-syncamends head only when non-finality period is long enough (configurable, currently set to 128 epochs).Which issues(s) does this PR fix?
Fixes #7695
Other notes for review