Mitigate potential overflow. ethereum/eth2.0-specs#2129 #7795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
changed the title
rauljordan
approved these changes
Nov 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #7795 +/- ##
==========================================
- Coverage 62.04% 61.99% -0.06%
==========================================
Files 430 430
Lines 30473 30475 +2
==========================================
- Hits 18908 18894 -14
- Misses 8624 8637 +13
- Partials 2941 2944 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
There is a potential, albeit unlikely, risk of an overflow for
get_block_root_at_slot.compute_start_slot_at_epochalready had overflow protection, so this exploit is probably not reproducable in any production code path.Which issues(s) does this PR fix?
Fixes ethereum/consensus-specs#2129 for Prysm.
Other notes for review
I did not test at runtime or sync with this change.