Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Sub Group for Herumi and Fix Edge Cases #7823

Merged
merged 9 commits into from
Nov 17, 2020
Merged

Check Sub Group for Herumi and Fix Edge Cases #7823

merged 9 commits into from
Nov 17, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 16, 2020 •
edited

What type of PR is this?

Mainnet Readiness

What does this PR do? Why is it needed?

  • Adds in Subgroup check for herumi (blst is already by default).
  • Update BLST
  • Add some more test cases
    - [x] Defensive check for infinite signatures.

Which issues(s) does this PR fix?

Fixes #7711

Other notes for review

@nisdas nisdas requested a review from a team as a code owner November 16, 2020 09:32
@nisdas nisdas added the Ready For Review A pull request ready for code review label Nov 16, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 168cffb into master Nov 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the checkSubGroup branch November 17, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@farazdagi farazdagi Awaiting requested review from farazdagi

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Subgroup Check For Respective Points
2 participants
@nisdas @rauljordan