Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardening aggregated attestation queue check #7826

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Nov 16, 2020

What type of PR is this?

Security

What does this PR do? Why is it needed?
Aggregated attestation in pending queue was missing the following:

  • FFG consistency check
  • Set seen cache after saving attestation to pool

This PR adds them

Which issues(s) does this PR fix?

Fixes # N/A

Other notes for review

@terencechain terencechain added Ready For Review A pull request ready for code review Security Security Related Issues labels Nov 16, 2020
@terencechain terencechain requested a review from a team as a code owner November 16, 2020 19:03
@terencechain terencechain self-assigned this Nov 16, 2020
nisdas
nisdas previously approved these changes Nov 17, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit ad5151f into master Nov 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the harden-queue-checks branch November 17, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review Security Security Related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants